[Dojo-interest] (Unofficial) FilteringTable enhancements

[Ross Thomas]

Sasha Firsov wrote:
> 
> I have tried to  make an abstraction layer spoken before and
> development has been done independently. In basic principles you gave,
> but they are dictated by original code, so CLA is not violated. I guess. 
> 

Works for me!  :-)



> I am not core contributor and my knowledge in dojo and JS OO
> programming is limited. That is why review need to be done. 
> The code review is a good practice anyway. And since project source is
> public anyway, there is no way to avoid discussions about sources. 
> The bad thing, it is not popular here. Can we / do we want to change
> it?
> 

If there is a public dojo-dev list then that may be a more appropriate forum
for discussion.  Or we can take it off-list.



> If you was fine with CLA, I will be trying to convince you to modify
> your patch a bit. Since, there are still problems, I am proposing to do
> the same with my patch. Comments are deeply appreciated.
> 

I'll take a look and let you know.

I visited the 'test' page and one can now see why Tom was reluctant to
include support for embedded widgets. Sloooowwwww.  The fact that
render() and the update methods can be called multiple times for the
same data doesn't help.



> I wish they will pass next to dojo core team as well. 
> 

I have no idea how the contributor code integration mechanism works.
It could be as simple as a single maintainer review or as complex as
a multiple 'committee' review.



> By the way, in your code there is some bug fixes, which worth to be
> filed in bug tracker and most likely shall have separate patch. 
> 

Really?  I wasn't aware of making any bug fixes as such.  It may have
been a side-effect of the functional enhancements but they were not
meant as bug fixes.  For instance, the 'null' patch *could* be considered
a bug fix except that the original behavior is the documented behavior.
As such that patch only constitutes an enhancement.  In fact, the patch
probably should've included a toggle to enable/disable the functionality.

Anyway, let's move this to your other thread and we'll consider this one
done except for any other reelases (e.g. 0.4.2) that may occur prior to
the stability of your patch.

Ross.
-- 
View this message in context: http://www.nabble.com/%28Unofficial%29-FilteringTable-enhancements-tf3023551.html#a8737938
Sent from the Dojo mailing list archive at Nabble.com.