[Dojo-interest] Tundra theme and CSS Sprites
Shane O'Sullivan
shaneosullivan1 at gmail.com
Thu Dec 20 16:26:12 UTC 2007
hi daniel,
Yes, trac is the place for this. File a bug and post the files - the
contributors can decide whether or not to take it on, but at least
it's logged and available for people to test.
Thanks for the effort
Shane
On 20/12/2007, Daniel <daniel.carrera at zmsl.com> wrote:
> Ok, I have a half-Sprite patch for tundra. It does a sprite for buttons,
> arrows and trees, but not for tabs (I don't have tabs in my app, so it's
> not relevant for me).
>
> Of these, only the tree sprite made any difference to my app. But it did
> remove 4 HTTP requests for me, and that's nice.
>
> If someone is interested, I can submit my patch somewhere. I don't know
> if Trac is the place for this, since this is just an idea, not a bug
> report. I won't feel offended if Dojo is not interested in this patch. I
> did it for me and my app. The patch is just a side-effect.
>
> Cheers,
> Daniel.
>
> Torrey Rice wrote:
> > I like the idea and would be interested in seeing the results and if it
> > works well we'll incorporate it. Currently the theme isn't super
> > optimized so there is definitely room to clean it up and reduce the
> > connections.
> >
> > Thanks,
> >
> > Torrey
> >
> > Daniel wrote:
> >> Hello,
> >>
> >> Ok, I have now optimized my skeleton app to the point where, according
> >> to Firebug+Yslow, the biggest issues are:
> >>
> >> - Not having ScrollBar.js in the build :(
> >> - Too many HTTP requests: 12 image downloads by the tundra theme.
> >>
> >> Has anyone given any thought to modifying tundra to use CSS sprites? For
> >> example, instead of having four images for buttons:
> >>
> >> buttonActive.png buttonDisabled.png
> >> buttonEnabled.png buttonHover.png
> >>
> >> One could have a single very tall image combining all four, and use
> >> something like:
> >>
> >> .button {background-image:url('images/buttonBg.png')}
> >> .buttonActive {background-position:0px 0px}
> >> .buttonHover {background-position:0px -22px}
> >> .buttonEnabled {background-position:0px -44px}
> >> .buttonDisabled {background-position:0px -66px}
> >>
> >> So you have 1 HTTP request instead of 4. You could do the same for the
> >> arrows, the tree widget, progress bar, and others.
> >>
> >> Has anyone thought of doing this? I ask because I'm thinking about doing
> >> this for my tundra-derived theme and I wonder whether (1) it's a waste
> >> of time or (2) it's a great idea and you'd like a patch.
> >>
> >> I'd probably try tomorrow or Friday. It's a fair bit of work, so I don't
> >> want to start it if there's a reason why this isn't a great idea. It
> >> looks like a great idea to me. Each HTTP request incurs a non-trivial
> >> overhead and this promises to cut that down significantly.
> >>
> >> Cheers,
> >> Daniel.
> >> _______________________________________________
> >> FAQ: http://dojotoolkit.org/support/faq
> >> Book: http://dojotoolkit.org/docs/book
> >> Forums: http://dojotoolkit.org/forum
> >> Dojo-interest at dojotoolkit.org
> >> http://dojotoolkit.org/mailman/listinfo/dojo-interest
> >>
> >>
> >
> > _______________________________________________
> > FAQ: http://dojotoolkit.org/support/faq
> > Book: http://dojotoolkit.org/docs/book
> > Forums: http://dojotoolkit.org/forum
> > Dojo-interest at dojotoolkit.org
> > http://dojotoolkit.org/mailman/listinfo/dojo-interest
> >
>
> _______________________________________________
> FAQ: http://dojotoolkit.org/support/faq
> Book: http://dojotoolkit.org/docs/book
> Forums: http://dojotoolkit.org/forum
> Dojo-interest at dojotoolkit.org
> http://dojotoolkit.org/mailman/listinfo/dojo-interest
>
More information about the Dojo-interest
mailing list