[Dojo-interest] Minor Issue with Dialog.js and lastest build (3647)

[Kris Leite]

Hi Bill,

Sorry, OK will do.

Thanks,
Kris

Bill Keese wrote:
>
> Thanks, fixed.
>
> BTW you should file bugs for patches, because patches sent to 
> dojo-interest will probably be ignored.  (Also there tabs tend to turn 
> into spaces, although that didn't seem to happen w/your mail.)
>
>
> Kris Leite wrote:
>> Dialog appears on load of HTML.  See test_Dialog.html and 
>> test_Dialog2.html
>>
>> The problem is the new onParentResized() routine not checking if the 
>> Dialog
>> is visible.  It is making it visible and adjusting size.  Attached is 
>> a patch that
>> will correct that behavior and improve general response since the 
>> Dialog box
>> was getting resized all the time and not just when it was showing.
>>
>> Thanks,
>> Kris
>>
>>
>> ------------------------------------------------------------------------
>>
>> Index: Dialog.js
>> ===================================================================
>> --- Dialog.js    (revision 3647)
>> +++ Dialog.js    (working copy)
>> @@ -188,10 +188,11 @@
>>  
>>          // Called when the browser window's size is changed
>>          onParentResized: function() {
>> -            this.sizeBackground();
>> -            this.placeDialog();
>> -            this.domNode.style.display="block";
>> -            this.onResized();
>> +            if(this.isShowing()){
>> +                this.sizeBackground();
>> +                this.placeDialog();
>> +                this.onResized();
>> +            }
>>          }
>>      }
>>  );
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Dojo FAQ: http://dojo.jot.com/FAQ
>> Dojo-interest at dojotoolkit.org
>> http://dojotoolkit.org/mailman/listinfo/dojo-interest
> _______________________________________________
> Dojo FAQ: http://dojo.jot.com/FAQ
> Dojo-interest at dojotoolkit.org
> http://dojotoolkit.org/mailman/listinfo/dojo-interest
>