[dojo-contributors] Stance on custom error types

Tom Trenka ttrenka at gmail.com
Mon Jun 4 11:08:40 EDT 2012


I prefer custom error types as well, but I can see there being a problem
with defining them using the typical one-object-per-module scheme.  Perhaps
something to implement in 2.0?

-- Tom

On Mon, Jun 4, 2012 at 7:46 AM, Ben Hockey <neonstalwart at gmail.com> wrote:

> i prefer custom errors too - for the reasons you mention.
>
> ben…
>
>
> On Jun 4, 2012, at 8:41 AM, Mark Wubben wrote:
>
> > Dojo seems to do custom errors by adding a `dojoType` property to the
> error instance. Examples in `dojo/request` and `dojo/io`. The new Promise
> code however uses a subclassed Error.
> >
> > dojo/promise/CancelError:
> >
> >       function CancelError(message){
> >               Error.captureStackTrace && Error.captureStackTrace(this,
> CancelError);
> >               this.message = message || "The deferred was cancelled.";
> >               this.name = "CancelError";
> >       };
> >       CancelError.prototype = new Error;
> >       CancelError.prototype.constructor = CancelError;
> >       return CancelError;
> >
> > I prefer subclassed errors because they're easier to instantiate and
> test for (either using `instanceof` or checking their `name`). We could
> even add `dojoType` properties.
> >
> > What is your preference?
> >
> > In any case, we need to standardize these across the codebase.
> >
> > --
> > Mark Wubben
> >
> > http://novemberborn.net
> > http://twitter.com/novemberborn
> >
> > _______________________________________________
> > dojo-contributors mailing list
> > dojo-contributors at mail.dojotoolkit.org
> > http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
>
>
> _______________________________________________
> dojo-contributors mailing list
> dojo-contributors at mail.dojotoolkit.org
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20120604/cbdfc364/attachment.htm 


More information about the dojo-contributors mailing list