[dojo-contributors] Stance on custom error types

Ben Hockey neonstalwart at gmail.com
Mon Jun 4 08:46:28 EDT 2012


i prefer custom errors too - for the reasons you mention.

ben…


On Jun 4, 2012, at 8:41 AM, Mark Wubben wrote:

> Dojo seems to do custom errors by adding a `dojoType` property to the error instance. Examples in `dojo/request` and `dojo/io`. The new Promise code however uses a subclassed Error.
> 
> dojo/promise/CancelError:
> 
> 	function CancelError(message){
> 		Error.captureStackTrace && Error.captureStackTrace(this, CancelError);
> 		this.message = message || "The deferred was cancelled.";
> 		this.name = "CancelError";
> 	};
> 	CancelError.prototype = new Error;
> 	CancelError.prototype.constructor = CancelError;
> 	return CancelError;
> 
> I prefer subclassed errors because they're easier to instantiate and test for (either using `instanceof` or checking their `name`). We could even add `dojoType` properties.
> 
> What is your preference?
> 
> In any case, we need to standardize these across the codebase.
> 
> --
> Mark Wubben
> 
> http://novemberborn.net
> http://twitter.com/novemberborn
> 
> _______________________________________________
> dojo-contributors mailing list
> dojo-contributors at mail.dojotoolkit.org
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 841 bytes
Desc: Message signed with OpenPGP using GPGMail
Url : http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20120604/0a54bcdb/attachment-0001.sig 


More information about the dojo-contributors mailing list