[dojo-contributors] 3-rd party compatibility as acceptance criteria?

Sasha Firsov suns at firsov.net
Mon Jun 4 00:17:07 EDT 2012


Dear all,
 From Ticket #14546 <http://bugs.dojotoolkit.org/ticket/14546>one of 
reasons to reject was:
     "it seems more important to be consistent with the other AMD loaders."

Now question goes to what level we should follow other libs?
I made require+Deferred compatible with DTK and require.js to the level 
they overlap:
test 
<http://simulationlabs.com/dojo/DojoPlay2012/libcommon/DTK1.7/util/doh/runner.html?testModule=lib/AMD/test/defferedAmdRequireTest&paths=lib,../../../lib> 
| sources <http://simulationlabs.com/dojo/DojoPlay2012/lib/AMD/test/>

original require() functionality reused and has not been changed. 
Unfortunately AMD error handling is not in agreement yet and DTK 
implementation differs. The plugin actually allows to hide the 
difference on AMD loaders implementation. But it will need additional 
conditional code to be cross-platform.

Question is: should the code to get accepted include the peace dedicated 
to serve 3-rd party libraries? Which ones?

IMO code should be enough extendable to be supported as branch for other 
environments but contributed code should be clean of foreign logic.

Another question, what to do with neat code so it will not get lost?

W/ respect,
Sasha
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20120603/0e0683b3/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3861 bytes
Desc: S/MIME Cryptographic Signature
Url : http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20120603/0e0683b3/attachment.p7s 


More information about the dojo-contributors mailing list