[dojo-contributors] Cometd code review?

Alex Russell alex at dojotoolkit.org
Wed May 27 23:01:28 EDT 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I hate the comment syntax, but that's neither here nor there. We'll  
live.

Ship it.

On May 25, 2009, at 3:55 PM, Greg Wilkins wrote:

>
> Judging from the lack of responses, a pair of brain damaged
> strong typed compiling java hacks have been able to produce some
> javascript code of such clarity that we have stunned into
> silence all you interpreting duck typers out there !-)
>
> No???
>
> Please review and tell us otherwise :)
>
> cheers
>
>
>
>
> Greg Wilkins wrote:
>>
>> All,
>>
>> the refactored cometd javascript (with a common base for both
>> jquery and dojox - eventually others), is now mostly functional
>> and is available in
>>
>> http://svn.cometd.com/trunk
>>
>> As this code has been mostly developed by two java hacks (Simone
>> and myself), we'd appreciate a bit of a code review from some
>> more js immersed folks to correct us from our evil strong
>> typing inspired ways.
>>
>> Currently the maven build takes dojo 1.3 and excludes the
>> current dojox/cometd and replaces it with the common based
>> one.   The intention is that eventually this code will replace
>> the code in dojox.cometd - so it needs to be of dojo quality
>> (and yes we can move the { and use tabs).
>>
>> cheers
>>
>> ps. If there are any prototype or ext.js users reading this,
>> it would also be great to see those frameworks use this
>> common implementation - to test it is indeed generic enough.
>>
>>
>>
>> --~--~---------~--~----~------------~-------~--~----~
>> You received this message because you are subscribed to the Google  
>> Groups "cometd-dev" group.
>> To post to this group, send email to cometd-dev at googlegroups.com
>> To unsubscribe from this group, send email to cometd-dev-unsubscribe at googlegroups.com
>> For more options, visit this group at http://groups.google.com/group/cometd-dev
>>
>> Visit the cometd website at http://www.cometd.com/
>> -~----------~----~----~----~------~----~------~--~---
>>
>
>
> _______________________________________________
> dojo-contributors mailing list
> dojo-contributors at mail.dojotoolkit.org
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors

- --
Alex Russell
slightlyoff at google.com
alex at dojotoolkit.org BE03 E88D EABB 2116 CC49 8259 CF78 E242 59C3 9723

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (Darwin)

iD8DBQFKHf6Jz3jiQlnDlyMRAr3tAJ42V/4p1wPuNylbBWDPsVJgwjXYbgCeKEwm
to4g+J7HRB3BDRZk1GfDrVg=
=h5FU
-----END PGP SIGNATURE-----


More information about the dojo-contributors mailing list