[dojo-contributors] Dojo style checker added

Bill Keese bill at dojotoolkit.org
Tue May 26 23:13:06 EDT 2009


Looks like you should just be ignoring regexs, same as you ignore 
strings and comments.

Shane O'Sullivan wrote:
> Hi Mike,
> 
> That's an awkward one alright.  I'll look into it.
> 
> Thanks
> 
> Shane
> 
> 2009/5/26 Mike Wilcox <mwilcox at sitepen.com>:
>> Hey Shane,
>>
>> FYI, the checker thinks this is a trailing comma:
>> dojox/embed/flashVars.js line 45
>> return txt.replace(/;{2,}/g,";");
>>
>> Not sure of an easy way to check for that. RegExp'ing a RegExp is tough.
>>
>>
>> Mike Wilcox
>> mwilcox at sitepen.com
>> http://www.sitepen.com
>> work: 650.968.8787 x218
>> cell:     214.697.4872
>>
>> On May 23, 2009, at 7:45 AM, Shane O'Sullivan wrote:
>>
>>> Hi All,
>>>
>>> I've checked in the style guide checker at util/checkstyle.  After
>>> fixing some accuracy issues, the number of style violations now stands
>>> at ~4700 across Dojo, Dijit and Dojox.
>>>
>>> You can see the announcement here -
>>> http://shaneosullivan.wordpress.com/2009/05/23/code-style-checker-for-dojo/
>>> for more information.  I'll get a doc page written soon.
>>>
>>> I've also created a ticket at http://bugs.dojotoolkit.org/ticket/9333
>>> to track style guide fixes, so feel free to reference that ticket.
>>>
>>> The current list of errors can be seen at
>>> http://skynet.ie/~sos/misc/dojoCheckstyle/util/checkstyle/checkstyleReport.html
>>>
>>> Shane
>>> _______________________________________________
>>> dojo-contributors mailing list
>>> dojo-contributors at mail.dojotoolkit.org
>>> http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
>>>
>> _______________________________________________
>> dojo-contributors mailing list
>> dojo-contributors at mail.dojotoolkit.org
>> http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
>>
> _______________________________________________
> dojo-contributors mailing list
> dojo-contributors at mail.dojotoolkit.org
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors



More information about the dojo-contributors mailing list