[dojo-contributors] No Side Effects Rejection

Nathan Toone toonetown at dojotoolkit.org
Mon May 11 11:56:53 EDT 2009


try{...}catch(e){...} by itself doesn't need a semicolon at the end.   
Adding one there should give an error that there is a statement that  
does nothing (ie just a semicolon is the statement that does nothing)

-Nathan

On May 11, 2009, at 9:49 AM, Mike Wilcox wrote:

> You are suggesting it's a format violation which is fine, but that's
> not what was throwing errors.
>
> As you proved though, it was the semi-colon in the wrong place. I
> guess I can see "return" being invalid compared to "return;"
>
> And as it turned out, a semi-colon after my try-catch was breaking
> embed.Flash:
>
> try{..}catch(e){...); <----- that semi colon wouldn't allow a commit!!
>
> I guess I would have to blame the validator for the improper message
> on that second one. is it reading that as two statements?
>
>
> Mike Wilcox
> mwilcox at sitepen.com
> http://www.sitepen.com
> work: 650.968.8787 x218
> cell:	  214.697.4872
>
> On May 11, 2009, at 10:32 AM, Peter E Higgins wrote:
>
>> Again, there is not allowed whitespace after "if" and before "{"
>>
>> Regards
>>
>> Mike Wilcox wrote:
>>>>> In FileUploader, it rejects my commit on this line:
>>>>>
>>>>> if (this._formNode) { return };
>>>>>
>>>>>
>>>> That doesn't pass style guidelines. It is moot. ;)
>>>>
>>>
>>> Sorry? Please explain. this._formNode needs to be explicitly  
>>> compared
>>> to null or something? (I wouldn't like that)
>>>
>>> Oh - it shouldn't have a semi-colon. That can't be it though.
>>>
>>> Mike
>>> _______________________________________________
>>> dojo-contributors mailing list
>>> dojo-contributors at mail.dojotoolkit.org
>>> http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
>>>
>>>
>>
>>
>> -- 
>> Peter E Higgins
>> Dojo Project Lead : http://dojotoolkit.org
>>
>> _______________________________________________
>> dojo-contributors mailing list
>> dojo-contributors at mail.dojotoolkit.org
>> http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
>>
>
> _______________________________________________
> dojo-contributors mailing list
> dojo-contributors at mail.dojotoolkit.org
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2433 bytes
Desc: not available
Url : http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20090511/5bb5e35a/attachment.p7s 


More information about the dojo-contributors mailing list