[dojo-contributors] No Side Effects Rejection

Peter E Higgins dante at dojotoolkit.org
Mon May 11 11:27:54 EDT 2009


> In FileUploader, it rejects my commit on this line:
>
> if (this._formNode) { return };
>
>   
also, in [17513] there was no warning for me:

sugr:form dante$ svn diff
Index: FileUploader.js
===================================================================
--- FileUploader.js     (revision 17506)
+++ FileUploader.js     (working copy)
@@ -1095,12 +1095,12 @@
                        // summary:
                        //              Build the form that holds the
fileInput
                        //
-                       if (this._formNode) { return };
+                       if(this._formNode){ return; }
 
-                       if (dojo.isIE) {
+                       if(dojo.isIE){
                                this._formNode =
document.createElement('<form enctype="multipart/form-data"
method="post">');
                                this._formNode.encoding =
"multipart/form-data";
-                       }else {
+                       }else{
                                this._formNode =
document.createElement('form');
                                this._formNode.setAttribute("enctype",
"multipart/form-data");
                        }
sugr:form dante$ svn commit -m "refs #7390 - super-minor style patch
testing jslint warning"
Sending        form/FileUploader.js
Transmitting file data .
Committed revision 17513.
sugr:form dante$



Regards

-- 
Peter E Higgins
Dojo Project Lead : http://dojotoolkit.org 



More information about the dojo-contributors mailing list