[dojo-contributors] No Side Effects Rejection

Peter E Higgins dante at dojotoolkit.org
Mon May 11 11:20:30 EDT 2009


> In FileUploader, it rejects my commit on this line:
>
> if (this._formNode) { return };
>   
That doesn't pass style guidelines. It is moot. ;)

(but I agree the 'no side effects' thing hits me often enough to say it
is broken)

I do, often:

anim && anim.stop && anim.stop();
anim = dojo.animateProperty(...)

Regards

-- 
Peter E Higgins
Dojo Project Lead : http://dojotoolkit.org 



More information about the dojo-contributors mailing list