[dojo-contributors] A new build tool for style guide violation checking

Shane O'Sullivan shaneosullivan1 at gmail.com
Mon May 11 04:15:50 EDT 2009


As usual, it's always the little things that get forgotten :-)  Sorry
about that, the patch is there now.

Shane

2009/5/11 Adam Peller <peller at gmail.com>:
> Shane - I don't see the patch.  Can you post it again?
>
> I think it might be best to add this as a pre- (fatal) or
> post-processing (warning) svn-hook.
>
> On Sun, May 10, 2009 at 6:35 PM, Shane O'Sullivan
> <shaneosullivan1 at gmail.com> wrote:
>> Hi All,
>>
>> Given that my first official check-in last week was riddled with style
>> guide violations, which I find it both difficult and boring to have to
>> look for (4 spaces looks VERY like a tab), I decided to have a go at
>> writing an extension to our build tools that does an optional check
>> for style guide violations.
>>
>> It obviously can't check for everything in the style guide, but it can
>> enforce many of the simpler guidelines.
>>
>> I've attached a patch file to http://bugs.dojotoolkit.org/ticket/9278
>> for people to look at.  It's extremely easy to use, instructions are
>> included in the ticket.
>>
>> What do people think?   Right now it only enforces a few rules, more
>> as a proof of concept than anything else.  However, it's extremely
>> easy to extend to enforce more.  Also, while some guidelines would be
>> too difficult to do in this manner, the fact that there's about 5000
>> violations in the toolkit right now of just these sample rules shows
>> that this can be a very valuable tool for tracking these issues.
>>
>> Thanks
>>
>> Shane
>> _______________________________________________
>> dojo-contributors mailing list
>> dojo-contributors at mail.dojotoolkit.org
>> http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
>>
> _______________________________________________
> dojo-contributors mailing list
> dojo-contributors at mail.dojotoolkit.org
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
>


More information about the dojo-contributors mailing list