[dojo-contributors] review of html-refactor work

Bryan Forbes bryan at reigndropsfall.net
Tue Jun 27 10:06:05 EDT 2006


On Tue, 2006-06-27 at 11:35 +0900, Bill Keese wrote:
> 
> Tom Trenka wrote:
> > Quick answer: no, none of the widget tests/code has been updated as of
> > yet, mainly because they have been very volatile and approval of the
> > direction in changes was kind of warranted before moving forward.
> > This has the potential to impact a very large portion of the library,
> > and it's a lot of work....
> 
> Sure.  But Bryan seemed to indicate that the changes were ready to be 
> merged to trunk.  Maybe I misinterpreted?

Sorry, I may have mislead.  I meant that if we wanted to, we could merge
the changes to trunk and start converting in trunk.

> 
> > 
> > Numeric indices were killed in favor of named properties, and will
> > definitely need to be changed through the codebase.  The named
> > property approach is one embodied by dojo.io.bind, which is (IMHO by
> > far) the most "Dojo-ish" code in the library; we should try to acheive
> > some consistency throughout the library, and this is one of the first
> > steps towards that.
> 
> Sure, sounds like a good idea.  I'm not against your changes; I just 
> want documentation.

I'll write up a wiki page.

> 
> Thanks,
> Bill
> _______________________________________________
> dojo-contributors mailing list
> dojo-contributors at dojotoolkit.org
> http://dojotoolkit.org/mailman/listinfo/dojo-contributors
> 
-- 
======================================================================
Bryan Forbes
bryan at reigndropsfall.net
http://www.reigndropsfall.net

"It does not take a majority to prevail, but rather an irate, tireless
minority keen to set brush fires in people's minds."
        - Samuel Adams, an architect of the Constitution

Key fingerprint = 3D7D B728 713A BB7B B8B1  5B61 3888 17E0 70CA 0F3D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20060627/e87f7031/attachment.sig 


More information about the dojo-contributors mailing list