[dojo-contributors] r4522

Bill Keese bill at dojotoolkit.org
Tue Jun 27 00:36:28 EDT 2006


Liu - maybe it's better to rename dojo.doc() to dojo.document()?

Neil Roberts wrote:
> Since the doc package isn't being used much currently, I'm going to 
> rename it to dojo.docs to make this easy
> 
> -Neil
> 
> On Jun 27, 2006, at 12:00 AM, Neil Roberts wrote:
> 
>> Okay, so let's do a quick exercise here...
>>
>> I want to create a new function, maybe I'll call it dojo.json()
>>
>> /me scans the src directory of dojo. Oops, I can't do that, there's a 
>> json.js file there
>>
>> Maybe I'll call it dojo.doc()
>>
>> /me scans the src directory of dojo. Oops, I can't do that, there's a 
>> doc.js file there.
>>
>> Having a function that overrides an entire dojo package seems like a 
>> bad idea.
>>
>> -Neil
>>
>> On Jun 26, 2006, at 7:18 PM, Alex Russell wrote:
>>
>>> On Monday 26 June 2006 3:57 pm, Bill Keese wrote:
>>>>> On 6/26/06, Bryan Forbes <bryan at reigndropsfall.net> wrote:
>>>>>> http://trac.dojotoolkit.org/changeset/4522
>>>>>> Why are we still using document.body?  I thought that we defined
>>>>>> dojo.html.body() because XHTML Strict documents don't have
>>>>>> document.body defined.  Is this true, and if so, can we change
>>>>>> references to document.body to dojo.html.body()?
>>>>>
>>>>> LiuCougar wrote:
>>>>> I prepared a patch for this
>>>>>
>>>>> please have a look
>>>>
>>>> Liu - Apparently we are supposed to use dojo.doc().body instead of
>>>> document.body and dojo.html.body()?
>>>
>>> I don't think that covers it. In a strict environment dojo.doc().body
>>> would expand out to document.documentElement.body, which I don't think
>>> is what we want. dojo.doc() *might* be useful, but perhaps not for
>>> this.
>>>
>>> Regards
>>>
>>> --Alex Russell
>>> alex at dojotoolkit.org BE03 E88D EABB 2116 CC49 8259 CF78 E242 59C3 9723
>>> _______________________________________________
>>> dojo-contributors mailing list
>>> dojo-contributors at dojotoolkit.org
>>> http://dojotoolkit.org/mailman/listinfo/dojo-contributors
>>
>> _______________________________________________
>> dojo-contributors mailing list
>> dojo-contributors at dojotoolkit.org
>> http://dojotoolkit.org/mailman/listinfo/dojo-contributors
>>
> 
> _______________________________________________
> dojo-contributors mailing list
> dojo-contributors at dojotoolkit.org
> http://dojotoolkit.org/mailman/listinfo/dojo-contributors



More information about the dojo-contributors mailing list