[dojo-contributors] review of html-refactor work

Bill Keese bill at dojotoolkit.org
Mon Jun 26 22:35:51 EDT 2006



Tom Trenka wrote:
> Quick answer: no, none of the widget tests/code has been updated as of
> yet, mainly because they have been very volatile and approval of the
> direction in changes was kind of warranted before moving forward.
> This has the potential to impact a very large portion of the library,
> and it's a lot of work....

Sure.  But Bryan seemed to indicate that the changes were ready to be 
merged to trunk.  Maybe I misinterpreted?

> 
> Numeric indices were killed in favor of named properties, and will
> definitely need to be changed through the codebase.  The named
> property approach is one embodied by dojo.io.bind, which is (IMHO by
> far) the most "Dojo-ish" code in the library; we should try to acheive
> some consistency throughout the library, and this is one of the first
> steps towards that.

Sure, sounds like a good idea.  I'm not against your changes; I just 
want documentation.

Thanks,
Bill



More information about the dojo-contributors mailing list