[dojo-contributors] Review request for #2247: xdomain builds: Get RichText to work with xdomain builds
liucougar at gmail.com
Fri Dec 22 19:44:24 EST 2006
savetextarea.style = "display:none;"
seems sufficient to me in this case, no need the other stuffs there, or no?
On 12/23/06, LiuCougar <liucougar at gmail.com> wrote:
> seems ok to me
> however, I would suggest to change _createSaveArea() to
> dojo.widget._getRichTextSaveArea() (not in the editor itself)
> which always return the textarea node (if it is not already created,
> just create it). so we don't need to have the id
> (dojo.widget.RichText.savedContent) in several places
> (or, I am thinking that rather than making use of a single textarea,
> it may be better to just use a textarea for each instance of richtext
> widget, but I am not sure... oh, never mind, just thinking loud)
> On 12/22/06, James Burke <jburke at dojotoolkit.org> wrote:
> > There is a document.write() issue with RichText and xdomain builds.
> > See the bug for info:
> > http://trac.dojotoolkit.org/ticket/2247
> > I have a patch attached to the ticket. I think I need either LiuCougar
> > or Alex to review, but I'm not sure. If anyone knows how to test the
> > correct operation of the dojo.widget.RichText.savedContent textarea in
> > RichText, then I can try testing the patch to make sure it works for
> > the problem it is trying to solve.
> > My guess is that textarea is used to support restoring RichText state
> > after either page reloads or browser back/forward.
> > James
> > _______________________________________________
> > dojo-contributors mailing list
> > dojo-contributors at dojotoolkit.org
> > http://dojotoolkit.org/mailman/listinfo/dojo-contributors
> "People's characters are strengthened through struggle against
> difficulties; they are weakened by comfort."
> - Old Chinese adage
"People's characters are strengthened through struggle against
difficulties; they are weakened by comfort."
- Old Chinese adage
More information about the dojo-contributors