[dojo-contributors] Request review for trac 2196 (dojo.uri, DomWidget and intern strings modification)
jburke at dojotoolkit.org
Mon Dec 18 00:32:44 EST 2006
I'm still doing final testing, but I would like a review for the
Intern strings by looking for dojo.uri.Uri/moduleUri calls instead of
(patch and new file attached to ticket)
I believe this change makes string interning stronger, and catches
more things, but it does modify dojo.uri and DomWidget.
When I brought this up on an old email thread, Cougar suggested
instead of using a data: URL for the dojo.uri.Uri replacement, have an
alternate Uri builder that took the interned string as another
argument. I went with that approach, since it required the least
invasive change to dojo.uri.
This change also moves the intern-strings build part into JS from Python.
If I don't hear any screaming, I will likely push this change in the
next day or two after I finish testing. So far looks good though.
More information about the dojo-contributors