[Dojo-checkins] bill - r27121 - in dijit/trunk/tests/layout: . robot
dojo-checkins-admin at dojotoolkit.org
dojo-checkins-admin at dojotoolkit.org
Thu Nov 24 23:33:54 EST 2011
Author: bill
Date: Thu Nov 24 20:33:54 2011
New Revision: 27121
Modified:
dijit/trunk/tests/layout/robot/GUI.html
dijit/trunk/tests/layout/robot/borderContainerTestFunctions.js
dijit/trunk/tests/layout/test_Gui.html
Log:
add comments so it's clear which assert failed, refs #11488
Modified: dijit/trunk/tests/layout/robot/GUI.html
==============================================================================
--- dijit/trunk/tests/layout/robot/GUI.html (original)
+++ dijit/trunk/tests/layout/robot/GUI.html Thu Nov 24 20:33:54 2011
@@ -24,12 +24,12 @@
doh.register("API", [
function initialConditions(){
- checkBCpanes(dijit.byId("main")); // This test will fail in opera because it thinks that the center content is taller than the border container. However, it displays fine.
- checkBCpanes(dijit.byId("mainSplit"));
- checkBCpanes(dijit.byId("embeddedBC"));
- checkBCpanes(dijit.byId("bottomSplit"));
- checkInside(dijit.byId("topTabs1"), dijit.byId("centerSplit"));
- doh.t(isVisible(dijit.byId("basdicFormTab").domNode));
+ checkBCpanes(dijit.byId("main"), "main checkBCpanes"); // This test will fail in opera because it thinks that the center content is taller than the border container. However, it displays fine.
+ checkBCpanes(dijit.byId("mainSplit"), "mainSplit checkBCpanes");
+ checkBCpanes(dijit.byId("embeddedBC"), "embeddedBC checkBCpanes");
+ checkBCpanes(dijit.byId("bottomSplit"), "bottomSplit checkBCpanes");
+ checkInside(dijit.byId("topTabs1"), dijit.byId("centerSplit"), "topTabs1 inside centerSplit");
+ doh.t(isVisible(dijit.byId("basicFormTab").domNode), "basicFormTab visible");
}
]);
@@ -111,7 +111,7 @@
doh.robot.mouseClick({left:true}, 500);
doh.robot.sequence(d.getTestCallback(function(){
- doh.is(undefined, dijit.byId("accTabs_tablist_bbtab3"));
+ doh.is(undefined, dijit.byId("accTabs_tablist_bbtab3"), "accTabs_tablist_bbtab3 undefined");
}), 1000);
return d;
@@ -181,7 +181,7 @@
doh.robot.mouseClick({left:true}, 500);
doh.robot.sequence(d.getTestCallback(function(){
- doh.is(undefined, dijit.byId("topTabs1_tablist_tabContainerInTabCP"));
+ doh.is(undefined, dijit.byId("topTabs1_tablist_tabContainerInTabCP"), "topTabs1_tablist_tabContainerInTabCP undefined");
}), 1000);
return d;
@@ -206,8 +206,8 @@
doh.robot.mouseClick({left:true}, 500);
doh.robot.sequence(d.getTestCallback(function(){
- checkInside(dijit.byId("bottomTabs1"), dijit.byId("embeddedBC"));
- checkInside(dijit.byId("bottomTabs2"), dijit.byId("embeddedBC"));
+ checkInside(dijit.byId("bottomTabs1"), dijit.byId("embeddedBC"), "bottomTabs1 inside embeddedBC");
+ checkInside(dijit.byId("bottomTabs2"), dijit.byId("embeddedBC"), "bottomTabs2 inside embeddedBC");
doh.t(isVisible(dijit.byId("btabB").domNode), "Tab 2 is not visible");
doh.t(isHidden(dijit.byId("btabA").domNode), "Tab 1 is not hidden");
}), 1000);
@@ -225,7 +225,7 @@
doh.robot.mouseClick({left:true}, 500);
doh.robot.sequence(d.getTestCallback(function(){
- doh.is(undefined, dijit.byId("bottomTabs1_tablist_btabC"));
+ doh.is(undefined, dijit.byId("bottomTabs1_tablist_btabC"), "bottomTabs1_tablist_btabC undefined");
}), 1000);
return d;
@@ -247,11 +247,11 @@
doh.robot.mouseRelease({left: true}, 500);
doh.robot.sequence(d.getTestCallback(function(){
- doh.t(isVisible(dijit.byId("dijit_layout_ContentPane_9").domNode));
- doh.t(isVisible(dijit.byId("dijit_layout_ContentPane_9_splitter").domNode));
- doh.t(isVisible(dijit.byId("btabAA").domNode));
- doh.t(isVisible(dijit.byId("dijit_layout_ContentPane_10").domNode));
- doh.t(isVisible(dijit.byId("dijit_layout_ContentPane_10_splitter").domNode));
+ doh.t(isVisible(dijit.byId("dijit_layout_ContentPane_9").domNode), "dijit_layout_ContentPane_9 visible");
+ doh.t(isVisible(dijit.byId("dijit_layout_ContentPane_9_splitter").domNode), "dijit_layout_ContentPane_9_splitter visible");
+ doh.t(isVisible(dijit.byId("btabAA").domNode), "btabAA visible");
+ doh.t(isVisible(dijit.byId("dijit_layout_ContentPane_10").domNode), "dijit_layout_ContentPane_10 visible");
+ doh.t(isVisible(dijit.byId("dijit_layout_ContentPane_10_splitter").domNode), "dijit_layout_ContentPane_10_splitter visible");
}), 1000);
return d;
@@ -267,12 +267,12 @@
doh.robot.mouseClick({left:true}, 500);
doh.robot.sequence(d.getTestCallback(function(){
- doh.t(isVisible(dijit.byId("btab2").domNode));
- doh.t(isHidden(dijit.byId("dijit_layout_ContentPane_9").domNode));
- doh.t(isHidden(dijit.byId("dijit_layout_ContentPane_9_splitter").domNode));
- doh.t(isHidden(dijit.byId("btabAA").domNode));
- doh.t(isHidden(dijit.byId("dijit_layout_ContentPane_10").domNode));
- doh.t(isHidden(dijit.byId("dijit_layout_ContentPane_10_splitter").domNode));
+ doh.t(isVisible(dijit.byId("btab2").domNode), "btab2 visible");
+ doh.t(isHidden(dijit.byId("dijit_layout_ContentPane_9").domNode), "dijit_layout_ContentPane_9 visible");
+ doh.t(isHidden(dijit.byId("dijit_layout_ContentPane_9_splitter").domNode), "dijit_layout_ContentPane_9_splitter visible");
+ doh.t(isHidden(dijit.byId("btabAA").domNode), "btabAA visible");
+ doh.t(isHidden(dijit.byId("dijit_layout_ContentPane_10").domNode), "dijit_layout_ContentPane_10 visible");
+ doh.t(isHidden(dijit.byId("dijit_layout_ContentPane_10_splitter").domNode), "dijit_layout_ContentPane_10_splitter visible");
}), 1000);
return d;
@@ -288,7 +288,7 @@
doh.robot.mouseClick({left:true}, 500);
doh.robot.sequence(d.getTestCallback(function(){
- doh.is(undefined, dijit.byId("bottomTabs_tablist_btab3"));
+ doh.is(undefined, dijit.byId("bottomTabs_tablist_btab3"), "bottomTabs_tablist_btab3 undefined");
}), 1000);
return d;
Modified: dijit/trunk/tests/layout/robot/borderContainerTestFunctions.js
==============================================================================
--- dijit/trunk/tests/layout/robot/borderContainerTestFunctions.js (original)
+++ dijit/trunk/tests/layout/robot/borderContainerTestFunctions.js Thu Nov 24 20:33:54 2011
@@ -43,7 +43,7 @@
);
}
- function checkBCpanes(/*BorderContainer*/ bc){
+ function checkBCpanes(/*BorderContainer*/ bc, /*String*/ comment){
// summary:
// Check that all the panes in this BorderContainer are in sane
// positions relative to each other. Assumes at most one pane
@@ -52,8 +52,8 @@
regions = {};
// Check all panes inside BorderContainer
- dojo.forEach(children, function(child){
- checkInside(child, bc);
+ dojo.forEach(children, function(child, comment){
+ checkInside(child, bc, comment);
regions[child.region] = child;
});
@@ -63,28 +63,28 @@
case "top":
dojo.forEach(bc.design == "sidebar" ? ["center", "bottom"] : ["left", "center", "right", "bottom"], function(region){
if(regions[region]){
- checkAbove(bc.id, child, regions[region]);
+ checkAbove(bc.id, child, regions[region], comment);
}
});
break;
case "bottom":
dojo.forEach(bc.design == "sidebar" ? ["center", "top"] : ["left", "center", "right", "top"], function(region){
if(regions[region]){
- checkAbove(bc.id, regions[region], child);
+ checkAbove(bc.id, regions[region], child, comment);
}
});
break;
case "left":
dojo.forEach(bc.design == "sidebar" ? ["top", "center", "bottom", "right"] : ["right"], function(region){
if(regions[region]){
- checkLeft(bc.id, child, regions[region]);
+ checkLeft(bc.id, child, regions[region], comment);
}
});
break;
case "right":
dojo.forEach(bc.design == "sidebar" ? ["top", "center", "bottom", "left"] : ["left"], function(region){
if(regions[region]){
- checkLeft(bc.id, regions[region], child);
+ checkLeft(bc.id, regions[region], child, comment);
}
});
break;
Modified: dijit/trunk/tests/layout/test_Gui.html
==============================================================================
--- dijit/trunk/tests/layout/test_Gui.html (original)
+++ dijit/trunk/tests/layout/test_Gui.html Thu Nov 24 20:33:54 2011
@@ -86,7 +86,7 @@
<!-- top tabs (marked as "center" to take up the main part of the BorderContainer) -->
<div id="topTabs1" data-dojo-type="dijit.layout.TabContainer" data-dojo-props='region:"top", tabStrip:true, splitter:true, style:"height:200px;"'>
- <div id="basdicFormTab" data-dojo-type="dijit.layout.ContentPane"
+ <div id="basicFormTab" data-dojo-type="dijit.layout.ContentPane"
data-dojo-props='title:"Basic Form Widgets",
style:"padding:10px;display:none;"'>
Hi friends of dijit
More information about the Dojo-checkins
mailing list