[Dojo-checkins] elazutkin - r20874 - in dijit/trunk: . form

dojo-checkins-admin at dojotoolkit.org dojo-checkins-admin at dojotoolkit.org
Sat Nov 21 09:57:30 EST 2009


Author: elazutkin
Date: Sat Nov 21 06:57:28 2009
New Revision: 20874

Modified:
   dijit/trunk/_DialogMixin.js
   dijit/trunk/form/_FormMixin.js
Log:
Renaming getEffectiveAttrValue to getNodeProp as agreed on the meeting, !strict, refs #8991.

Modified: dijit/trunk/_DialogMixin.js
==============================================================================
--- dijit/trunk/_DialogMixin.js	(original)
+++ dijit/trunk/_DialogMixin.js	Sat Nov 21 06:57:28 2009
@@ -63,7 +63,7 @@
 			this._firstFocusItem = elems.lowest || elems.first || dialogNode;
 			this._lastFocusItem = elems.last || elems.highest || this._firstFocusItem;
 			if(dojo.isMoz && this._firstFocusItem.tagName.toLowerCase() == "input" &&
-					dojo.getEffectiveAttrValue(this._firstFocusItem, "type").toLowerCase() == "file"){
+					dojo.getNodeProp(this._firstFocusItem, "type").toLowerCase() == "file"){
 				// FF doesn't behave well when first element is input type=file, set first focusable to dialog container
 				dojo.attr(dialogNode, "tabIndex", "0");
 				this._firstFocusItem = dialogNode;

Modified: dijit/trunk/form/_FormMixin.js
==============================================================================
--- dijit/trunk/form/_FormMixin.js	(original)
+++ dijit/trunk/form/_FormMixin.js	Sat Nov 21 06:57:28 2009
@@ -149,7 +149,7 @@
 
 				// TODO: widget values (just call attr('value', ...) on the widget)
 
-				// TODO: maybe should call dojo.getEffectiveAttrValue() instead
+				// TODO: maybe should call dojo.getNodeProp() instead
 				switch(element.type){
 					case "checkbox":
 						element.checked = (name in myObj) &&


More information about the Dojo-checkins mailing list