[Dojo-checkins] [dojo] #9691: Fix BorderContainer slider's _recalc property

dojo trac at dojotoolkit.org
Thu Nov 19 22:49:10 EST 2009


#9691: Fix BorderContainer slider's _recalc property
--------------------+-------------------------------------------------------
 Reporter:  peller  |        Owner:  bill  
     Type:  defect  |       Status:  closed
 Priority:  normal  |    Milestone:  1.4   
Component:  Dijit   |      Version:  1.3.2 
 Severity:  normal  |   Resolution:  fixed 
 Keywords:          |  
--------------------+-------------------------------------------------------
Changes (by bill):

  * status:  assigned => closed
  * resolution:  => fixed


Comment:

 (In [20866]) !BorderContainer fixes:

   1. Make addChild() call layout() rather than layoutChildren(), so that
 _computeSplitterThickness() is called (fixes #9881).
   2. Get rid of problematic dijit.layout._Splitter.oppNode parameter where
 (for example) the left splitter points to right child's domNode.  oppNode
 sometimes had the wrong value (or no value), like when the right child
 didn't exist when the left splitter was initialized.
   3. Get rid of _recalc property to avoid similar problems, and also
 because it's an unnecessary optimization; calling computeMaxSize() each
 time the user drags a splitter is fine, and safer.  Even moving by
 keystroke on IE6 seems fine.  (fixes #9691)
   4. Get rid of this._maxSize and this._minSize and just use local
 variables

 !strict

-- 
Ticket URL: </ticket/9691#comment:3>
dojo <http://dojotoolkit.org/>
The Dojo UI Toolkit


More information about the Dojo-checkins mailing list